id variable is added to support subtitle and close caption #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id variable is added to support subtitle and close caption hex code , so that we can find the language code using it
|
id variable is added to support subtitle and close caption |
|
Do we need to update any test to ensure the ID field gets populated? |
|
not needed |
|
if changes are looking ok could you please merge it , bcz I need it in my project on urgent bases |
|
I'm sorry for not getting back sooner. But a test would be useful. None of the fixtures seem to have the "id" field a the moment, so I'd like to ensure we have a working example. |
|
Closing in favour of #343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id variable is added to support subtitle and close caption hex code , so that we can find the language code using it